RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v2]
Matthias Baesken
mbaesken at openjdk.org
Tue Mar 11 09:10:03 UTC 2025
On Mon, 10 Mar 2025 18:51:53 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> make/modules/java.management/Lib.gmk line 33:
>>
>>> 31: ## Build libmanagement
>>> 32: ################################################################################
>>> 33:
>>
>> Why remove the comment header. This pattern is used throughout the `make/modules/*/Lib.gmk` files.
>
> My motivation was that the comment brings not much value because it just states the obvious. But if you like I can bring back the comment.
I brought back the comment, maybe it is better to keep it because of consistency.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23966#discussion_r1988749705
More information about the build-dev
mailing list