RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v2]

[Kevin Walls]

On Tue, 11 Mar 2025 09:04:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Bring back comment

make/modules/java.management/Lib.gmk line 35:

> 33: 
> 34: LIBMANAGEMENT_OPTIMIZATION := HIGH
> 35: ifeq ($(call isTargetOs, linux)+$(COMPILE_WITH_DEBUG_SYMBOLS), true+true)

On removal of `ifeq ($(call isTargetOs, linux)+$(COMPILE_WITH_DEBUG_SYMBOLS), true+true)`
..are we saying this is redundant?

It reads like Linux builds with LOW, and this change will change that to HIGH ?

I tested existing build and see -O2 in Linux fastdebug and release builds.  So this ifeq wasn't doing anything?

Windows fastdebug and release I just checked and saw -O1, I'm not sure why that is.

We do the same thing in make/modules/jdk.management/Lib.gmk so both these management locations should probably be treated the same.

(The same comparison is in make/modules/java.base/lib/CoreLibraries.gmk affecting LIBVERIFY_OPTIMIZATION, but no need to expand this change beyond the management area.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23966#discussion_r1989256782