RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v3]

[Kevin Walls]

On Tue, 11 Mar 2025 14:14:16 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust jdk.management/Lib.gmk

Hi,  I wasn't saying this is wrong, but that the change should say how it makes things better.  The issues says there are some things most likely not needed.  We should be a bit clearer than that, like:


The removal of `ifeq ($(call isTargetOs, linux)+$(COMPILE_WITH_DEBUG_SYMBOLS), true+true)`
Was this always redundant, and does removing it make no change to current build options?
If so, great, let's remove the useless makefile lines.


Remove a compiler directive to avoid unused var warnings, but change the code to make it imply a method has no return value when actually it returns a value: I think you could argue this either way, so I asked if it's really worthwhile.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23966#issuecomment-2714681001