RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v3]
Kevin Walls
kevinw at openjdk.org
Tue Mar 11 18:40:03 UTC 2025
On Tue, 11 Mar 2025 14:14:16 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Adjust jdk.management/Lib.gmk
Yes - this might be a really good change, to move the optimization level up, but we need to be clear what is happening and why, in case it throws up some new issues.
Yes, I would agree with handling the unused variable changes separately. If somebody finds a problem with the opt level, it can be reverted without other complications.
(and separately, maybe it's worth handling the return value of GetOptionalSupport, which in our implementation really can't be -1 unless you call it wrongly, but strange things happen and things change 8-) )
I can do some tiers of CI testing to see if any odd issues pop up.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23966#issuecomment-2715367338
More information about the build-dev
mailing list