RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files

[Patrick Zhang]

On Thu, 20 Mar 2025 01:10:19 GMT, Patrick Zhang <qpzhang at openjdk.org> wrote:

> Wouldn't just the change in JvmFlags.gmk be enough to solve your issue?

Forgot to mention, one of my initial try-outs (hacking) was: Remove `$(EXTRA_CFLAGS)` from `JVM_CFLAGS`, based on an assumption that all source files under `$(TOPDIR)/src/hotspot` are (according to `hotspot/variant-server/libjvm/objs/BUILD_LIBJVM.d`) and will be C++ files only which has `$(EXTRA_CXXFLAGS)` and does **not** need `$(EXTRA_CFLAGS)` . This practically solved the issue I observed, however I don't think it was an elegant solution. Is this more acceptable than adding parameters to `SetupNativeCompilation` (actually the call to `SetupJdkLibrary)? 


diff --git a/make/hotspot/lib/JvmFlags.gmk b/make/hotspot/lib/JvmFlags.gmk
index 97538da74c7..57b632ee532 100644
--- a/make/hotspot/lib/JvmFlags.gmk
+++ b/make/hotspot/lib/JvmFlags.gmk
@@ -91,7 +91,6 @@ JVM_CFLAGS += \
     $(JVM_CFLAGS_TARGET_DEFINES) \
     $(JVM_CFLAGS_FEATURES) \
     $(JVM_CFLAGS_INCLUDES) \
-    $(EXTRA_CFLAGS) \
     #

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24115#issuecomment-2739150006