RFR: 8350801: Add a code signing hook to the JDK build system [v2]
Frederic Thevenet
fthevenet at openjdk.org
Tue Mar 25 14:17:51 UTC 2025
On Tue, 25 Mar 2025 11:24:51 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Frederic Thevenet has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Simplified CallSigningHook logic
>> - Reapply "Expand the UTIL_ARG_WITH macro to accept and check for executable files as an argument"
>>
>> This reverts commit ca7ddc6ba337e723a80e4794633b073dda5c0951.
>
> make/autoconf/jdk-options.m4 line 996:
>
>> 994: SIGNING_HOOK_ENABLED=true
>> 995: AC_SUBST(SIGNING_HOOK)
>> 996: AC_MSG_RESULT([yes])
>
> Suggestion:
>
>
> AC_MSG_CHECKING([for signing hook])
>
> ...
>
> AC_MSG_RESULT([$SIGNING_HOOK])
>
> ...
>
> AC_MSG_RESULT([none])
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23807#discussion_r2012206798
More information about the build-dev
mailing list