RFR: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk

[Magnus Ihse Bursie]

On Mon, 5 May 2025 21:39:15 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> .github/workflows/test.yml line 95:
>> 
>>> 93:           - test-name: 'hs/tier1 common'
>>> 94:             test-suite: 'test/hotspot/jtreg/:tier1_common'
>>> 95:             debug-suffix: ${{ inputs.debug-suffix }}
>> 
>> I don't understand why these changes were needed? What are you doing with the debug suffix?
>
> The hard-coded `debug-suffix: -debug` maps to run the hs/tier1 tests on `debug` build only. However, we can't build `debug` binary for static JDK yet due to the resource/space issue in GHA. I documented some related details in https://bugs.openjdk.org/browse/JDK-8355452?focusedId=14775969&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14775969.
> 
> Changing hard-coded `-debug` to `${{ inputs.debug-suffix }}` allows us to set '' for `debug-suffix`, which maps to run hs/tier1 tests on `static-jdk` `release` build for now.

Ok, I see. Then it makes sense.

>> .github/workflows/test.yml line 182:
>> 
>>> 180:           BOOT_JDK=${{ steps.bootjdk.outputs.path }}
>>> 181:           JDK_UNDER_TEST=${{ steps.bundles.outputs.static-jdk-path }}
>>> 182:           JDK_FOR_COMPILE=${{ steps.bundles.outputs.jdk-path }}
>> 
>> Do we really need to duplicate all this code? From what I can see, this is just to be able to send in the JDK_FOR_COMPILE argument, right?
>
>> Do we really need to duplicate all this code? From what I can see, this is just to be able to send in the JDK_FOR_COMPILE argument, right?
> 
> Yaml syntax is new to me. I went with that as it worked. :-) The static case sets the `JDK_FOR_COMPILE`|`JDK_UNDER_TEST` and `EXTRA_PROBLEM_LISTS` in `JTREG`. Any suggestion?

I think you could add something like 

${{ inputs.extra-test-options }}

in the `make test-prebuilt` command line, and then set it up as arguments when calling the test workflow.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24992#discussion_r2075767888
PR Review Comment: https://git.openjdk.org/jdk/pull/24992#discussion_r2075771620