RFR: 8282493: Add --with-jcov-modules convenience option [v3]
Erik Joelsson
erikj at openjdk.org
Tue May 6 21:57:17 UTC 2025
On Tue, 6 May 2025 20:59:35 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> make/RunTests.gmk line 1376:
>>
>>> 1374: jcov-gen-report: jcov-stop-grabber
>>> 1375: $(call LogWarn, Generating JCov report ...)
>>> 1376: $(call ExecuteWithLog, $(JCOV_SUPPORT_DIR)/run-jcov-repgen,
>>
>> Shouldn't there be a backslash at the end of this line?
>
> On windows+cygwin:
>
> Generating JCov report ...
> RunTests.gmk:1378: *** unterminated call to function 'call': missing ')'. Stop.
> make[2]: *** [make/Main.gmk:820: jcov-test] Error 2
It should indeed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24481#discussion_r2076391734
More information about the build-dev
mailing list