RFR: 8351029: IncludeCustomExtension does not work on cygwin with source code below /home

[Magnus Ihse Bursie]

On Wed, 7 May 2025 21:21:14 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Is it the `cd $$(TOPDIR)` when calling make from `DefineMakeTargets` that is causing the mismatch that you are correcting by including SPEC here?

No, it is the `-f $$(TOPDIR)/make/GenerateFindTests.gmk` argument to make. This is added verbatim by make to `MAKEFILE_LIST`, and then our string processing in make/common/MakeIncludeStart.gmk does not work properly, since it tries to strip off $(TOPDIR), which at that point is different.

My first attempt was to re-create the TOPDIR in PreInit the same way as it is created in spec.gmk, but that would include mimicking the entire UTIL_FIXUP_PATH which seemed to be just too much work and too fragile.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25100#issuecomment-2860452248