RFR: 8351029: IncludeCustomExtension does not work on cygwin with source code below /home [v2]

[Magnus Ihse Bursie]

On Wed, 7 May 2025 22:50:52 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> If you check out your source code in Cygwin, somewhere under /home/... (as opposed to /cygpath/...), IncludeCustomExtension does not work.
>> 
>> The problem is that TOPDIR gets a different lexical value from the spec.gmk file when setup in Makefile, even if this was the same directory. Since THIS_INCLUDE is calculated as a relative path by string substitution of $(TOPDIR), the path failed to relativize correctly.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into fix-preinit-topdir
>  - Alternative solution
>  - 8351029: IncludeCustomExtension does not work on cygwin with source code below /home

There are no obvious place where to put that comment, and I don't want to sprinkle the code with comments about it everwhere it is used. I'd say that those future archaeologists will have to use `git blame` to find this PR, if it is not clear to them how the variable is used...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25100#issuecomment-2865783097