RFR: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk [v3]
Jiangli Zhou
jiangli at openjdk.org
Mon May 12 18:48:17 UTC 2025
> Please review this PR that adds a `test-linux-x64-static` job, which runs tier1 tests on the static-jdk 'release' binary created from the `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` parameter. `static-suffix` is added to the bundle name.
> - Add `static-jdk-path` output.
> - Unpack static bundles in bundles/static-jdk.
>
> .github/actions/upload-bundles/action.yml
> - Add `static-suffix` parameter. The `static-suffix` is added to the bundle name. The `linux-x64-static` build job sets the parameter as "-static". In other jobs, `static-suffix` not set.
>
> .github/workflows/build-linux.yml
> - Pass `${{ inputs.static-suffix }}` to upload-bundles action, with the `static-suffix` parameter.
>
> .github/workflows/main.yml
> - Build `product-bundles test-bundles static-jdk-bundles` for `linux-x64-static` job.
> - Add `test-linux-x64-static` job. It currently tests on `release` binary and not `debug` binary, since there are build issue with `debug` due to GHA resource/space limit.
> - Set `debug-suffix` for the existing non-static test jobs, which test on `debug` binaries.
>
> .github/workflows/test.yml
> - Add `debug-suffix` parameter and replace `debug-suffix: -debug` with `debug-suffix: ${{ inputs.debug-suffix }}` in hs/tier1 tests in the test matrix. The existing test jobs (on non-static JDK) set `debug-suffix` to `-debug` to test on `debug` binaries.
> - Add `static-suffix` parameter. Add `${{ inputs.static-suffix }}` to the test result artifact name.
> - Add `run-tests-static`.
> - Add step for notifying test failures on static JDK.
>
> @shipilev Could you please help review this change? Thanks!
Jiangli Zhou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 27 additional commits since the last revision:
- Add jdk, langtools and lib-test ProblemList-StaticJdk.txt for test-linux-x64-static.
- Merge branch 'master' into JDK-8355452
- Experiment based on magicus comment:
- Add build-linux-x64 to 'needs' in test-linux-x64-static.
- Remove product-bundles test-bundles from build-linux-x64-static.
- Fix typo.
- Export static-problemlist-path in 'path' step.
- Remove inputs.static-suffix check when notify test failure.
- Replace $(pwd) with `pwd` to form the path to static JDK problemlist.
- Use different id fot test on static. Add step to notify failures on static JDK.
- - Change run-tests-on-static id to run-tests id.
- Remove extra '-' before '-static' in artifact_name.
- Don't set debug-suffix for static test job, since that causes incorrect bundle name used.
- ... and 17 more: https://git.openjdk.org/jdk/compare/c51ee97a...a472463a
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24992/files
- new: https://git.openjdk.org/jdk/pull/24992/files/498acd39..a472463a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24992&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24992&range=01-02
Stats: 41955 lines in 1370 files changed: 28518 ins; 7475 del; 5962 mod
Patch: https://git.openjdk.org/jdk/pull/24992.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24992/head:pull/24992
PR: https://git.openjdk.org/jdk/pull/24992
More information about the build-dev
mailing list