RFR: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk [v12]
Jiangli Zhou
jiangli at openjdk.org
Thu May 22 00:46:55 UTC 2025
On Wed, 21 May 2025 22:09:15 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs tier1 tests on the static-jdk 'release' binary created from the `linux-x64-static` build job in GHA. Following are the details on the changes:
>>
>> .github/actions/get-bundles/action.yml.
>> - Add `static-suffix` parameter. `static-suffix` is added to the bundle name.
>> - Add `static-jdk-path` output.
>> - Unpack static bundles in bundles/static-jdk.
>>
>> .github/actions/upload-bundles/action.yml
>> - Add `static-suffix` parameter. The `static-suffix` is added to the bundle name. The `linux-x64-static` build job sets the parameter as "-static". In other jobs, `static-suffix` not set.
>>
>> .github/workflows/build-linux.yml
>> - Pass `${{ inputs.static-suffix }}` to upload-bundles action, with the `static-suffix` parameter.
>>
>> .github/workflows/main.yml
>> - Build `product-bundles test-bundles static-jdk-bundles` for `linux-x64-static` job.
>> - Add `test-linux-x64-static` job. It currently tests on `release` binary and not `debug` binary, since there are build issue with `debug` due to GHA resource/space limit.
>> - Set `debug-suffix` for the existing non-static test jobs, which test on `debug` binaries.
>>
>> .github/workflows/test.yml
>> - Add `debug-suffix` parameter and replace `debug-suffix: -debug` with `debug-suffix: ${{ inputs.debug-suffix }}` in hs/tier1 tests in the test matrix. The existing test jobs (on non-static JDK) set `debug-suffix` to `-debug` to test on `debug` binaries.
>> - Add `static-suffix` parameter. Add `${{ inputs.static-suffix }}` to the test result artifact name.
>> - Add `run-tests-static`.
>> - Add step for notifying test failures on static JDK.
>>
>> @shipilev Could you please help review this change? Thanks!
>
> Jiangli Zhou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 36 additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8355452
> - Merge branch 'master' into JDK-8355452
> - Merge branch 'master' into JDK-8355452
> - Address magicus comment:
> - Replaced '${{ inputs.static-suffix }}' != '' to '${{ inputs.static-suffix }}' == '-static', to be more consistent.
> - Add missing '.outputs' after 'steps.extra-options'.
> - Remove 'if: ${{ inputs.static-suffix != '-static' }}' check from run-test step.
> - Add 'extra-options' step to setup additional options. Remove run-test-static and the related notify failure steps.
> - Add $static_jdk_bundle_zip$static_jdk_bundle_tar_gz for bundle-found check.
> - Add separate download-static-bundles.
> - Add jdk, langtools and lib-test ProblemList-StaticJdk.txt for test-linux-x64-static.
> - ... and 26 more: https://git.openjdk.org/jdk/compare/2472b1b0...fa162b7f
All builds/tests in https://github.com/jianglizhou/jdk/actions/runs/15173492211 are green. I'll integrate tomorrow morning, just to be extra cautious (currently it's late afternoon PT time).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24992#issuecomment-2899593380
More information about the build-dev
mailing list