RFR: 8349665: Make clean removes module-deps.gmk
Magnus Ihse Bursie
ihse at openjdk.org
Tue May 27 20:48:13 UTC 2025
On Thu, 3 Apr 2025 09:18:07 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only generate module-deps.gmk once at the start of Init.gmk. This causes `make clean <some other target>` to first generate and then remove module-deps.gmk after which the rest of the build proceeds without a module-deps.gmk, causing problems with dependencies.
Dang it! I tried a lot of approaches in a throwaway branch, and I thought I kept the correct one and tested it. Back to the drawing board, I guess. Thanks for double checking!
Now I believe it should work for real this time.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24406#issuecomment-2784565328
PR Comment: https://git.openjdk.org/jdk/pull/24406#issuecomment-2913993125
More information about the build-dev
mailing list