RFR: 8357920: Add .rej and .orig to .gitignore

Magnus Ihse Bursie ihse at openjdk.org
Wed May 28 09:22:56 UTC 2025


On Wed, 28 May 2025 09:19:27 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> .gitignore line 26:
>> 
>>> 24: /.lldbinit
>>> 25: **/core.[0-9]*
>>> 26: *.rej
>> 
>> How about use below config instead. It will ignore all the related diff files in root directory and in the any sub-directory.
>> 
>> 
>> **/*.rej
>> **/*.orig
>
> Patterns without a `/` in them will match in all subdirectories, so your suggestion is just redundant. I see we have some places where this was done previously; maybe we should remove that to avoid the confusion. `**` is only relevant if you want to do something like `src/**/*.java`.

And if you really wanted to just match files in the root directory, you'd have to write `/*.rej`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25474#discussion_r2111370705


More information about the build-dev mailing list