RFR: 8355725: SPEC_FILTER stopped working
Erik Joelsson
erikj at openjdk.org
Wed May 28 14:22:52 UTC 2025
On Wed, 28 May 2025 00:06:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> From the bug description:
>
> The SPEC_FILTER make variable is meant to be used to create small documentation bundles that just contain some selected files. Example usage:
>
> `make docs-specs-zip SPEC_FILTER="%-jls.md copyright.html %logo.gif resources"`
>
> The fix for [JDK-8349143](https://bugs.openjdk.org/browse/JDK-8349143) caused the feature to stop working: no matter what the filter variables says, all the specs get built. This is a regression, old behavior needs to be restored.
Have you considered using `?=` for conditional assignments? It's not exactly the same here though as an empty value would be different from no value.
-------------
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25476#pullrequestreview-2875310361
More information about the build-dev
mailing list