RFR: 8347831: Re-examine version check when cross linking [v2]
Alan Bateman
alanb at openjdk.org
Fri Nov 7 10:25:05 UTC 2025
On Fri, 7 Nov 2025 00:46:44 GMT, Henry Jen <henryjen at openjdk.org> wrote:
>> This PR include build changes from @magicus and jlink change to verify the build signature.
>>
>> Tested with local builds for MacOS and Linux as below shows that cross linking with same build is working while linking with different build failed with error message.
>>
>> ❯ export JAVA_HOME=./build/macosx-x86_64-server-fastdebug/images/jdk-bundle/jdk-26.jdk/Contents/Home
>>
>> ❯ java --version
>> openjdk 26-internal 2026-03-17
>> OpenJDK Runtime Environment (fastdebug build 26-internal-adhoc.hjen.JDK-8347831)
>> OpenJDK 64-Bit Server VM (fastdebug build 26-internal-adhoc.hjen.JDK-8347831, mixed mode, sharing)
>>
>> ❯ jlink --version
>> 26-internal
>>
>> ❯ jlink --module-path ./build/linux-x86_64-server-release/images/jdk/jmods --add-modules java.base --output linux
>>
>> ❯ jlink --add-modules java.base --output macos
>>
>> ❯ jlink --module-path ~/linux/jdk-25.0.1/jmods --add-modules java.base --output linux25
>> Error: jlink build N/A-26-internal-adhoc.hjen.JDK-8347831-2026-03-17 does not match target java.base build N/A
>>
>> ❯ jlink --module-path /Library/Java/JavaVirtualMachines/jdk-25.jdk/Contents/Home/jmods --add-modules java.base --output macos25
>> Error: jlink build N/A-26-internal-adhoc.hjen.JDK-8347831-2026-03-17 does not match target java.base build N/A
>
> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>
> Use release.txt from java.base module in current and target for comparison
src/java.base/share/classes/jdk/internal/jmod/resources/release.txt.template line 1:
> 1: @@COMPANY_NAME@@-@@VERSION_STRING@@-@@VERSION_DATE@@
jdk.internal.jmod is for the code to access JMOD files. I think we'll need to find a better location for release.txt Putting in the top-level directory of java.base would create an attractive nuisance so jdk.internal.* is better. Maybe put it in misc for now until we find somewhere better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28155#discussion_r2502620339
More information about the build-dev
mailing list