RFR: 8347831: Re-examine version check when cross linking [v4]

Henry Jen henryjen at openjdk.org
Tue Nov 11 16:38:05 UTC 2025


On Tue, 11 Nov 2025 09:58:33 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactoring to clarify version checking cases
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 625:
> 
>> 623:         throw new IllegalArgumentException(taskHelper.getMessage("err.jlink.version.mismatch",
>> 624:                 currentRelease,
>> 625:                 targetRelease));
> 
> Would it be possible to paste in the error that the jlink user will see? (assuming jdk.debug is not set). I just want to be sure that the IllegalArgumentException isn't shown to the user.

Instead of showing N/A, it is now show missing. Output is still like above in the description.


jlink --module-path /Library/Java/JavaVirtualMachines/jdk-25.jdk/Contents/Home/jmods --add-modules java.base --output macos25
Error: jlink build N/A-26-internal-adhoc.hjen.JDK-8347831-2026-03-17 does not match target java.base build missing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28155#discussion_r2514914094


More information about the build-dev mailing list