RFR: 8371988: Typo in JTREG_TMIEOUT_FACTOR and TMIEOUT_FACTOR should be corrected
Jaikiran Pai
jpai at openjdk.org
Mon Nov 17 15:42:15 UTC 2025
On Mon, 17 Nov 2025 13:34:09 GMT, Ramesh Bhagavatam Gangadhar <rgangadhar at openjdk.org> wrote:
> There are two typos in https://github.com/openjdk/jdk/blob/master/doc/testing.md
>
> https://github.com/openjdk/jdk/blob/master/doc/testing.md?plain=1#L292
>
> Wrong: JTREG_TMIEOUT_FACTOR
> Correct: JTREG_TIMEOUT_FACTOR
>
>
> Wrong: JTREG="TMIEOUT_FACTOR...
> Correct: JTREG="TIMEOUT_FACTOR...
Hello Ramesh, that is actually an intentional typo.
> but using the keyword format
means that the `JTREG` variable is parsed and verified for correctness, so
`JTREG="TMIEOUT_FACTOR=8"` would give an error, while `JTREG_TMIEOUT_FACTOR=8`
would just pass unnoticed.
What it's trying to explain there is that the usage of `JTREG=` style will catch and report such typos whereas using `JTREG_` will not catch that typo.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28351#issuecomment-3542518147
More information about the build-dev
mailing list