RFR: 8366094: Sealed graph for nested types creates broken links [v3]

Chen Liang liach at openjdk.org
Tue Nov 18 16:41:32 UTC 2025


On Fri, 14 Nov 2025 10:07:07 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Please review a change to fix broken links in sealed type hierarchy graphs for nested types. The problem is that SVG files for nested types use the names of enclosing types as parent directories. Therefore, links from nested type SVGs  must have a matching `../` for each enclosing type. 
>> 
>> Fixed graphs for some nested sealed types: 
>>  - [ClassFile.Option](https://cr.openjdk.org/~hannesw/8366094/api.00/java.base/java/lang/classfile/ClassFile.Option.html)
>>  - [Signature.RefTypeSig](https://cr.openjdk.org/~hannesw/8366094/api.00/java.base/java/lang/classfile/Signature.RefTypeSig.html)
>>  - [TypeAnnotation.TargetInfo](https://cr.openjdk.org/~hannesw/8366094/api.00/java.base/java/lang/classfile/TypeAnnotation.TargetInfo.html)
>> 
>> There is currently no test coverage for the sealed graph taglet. I tested the fix manually, a test should be added with [JDK-8366828](https://bugs.openjdk.org/browse/JDK-8366828).
>
> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment to explain SVG naming scheme

These links are weird right now. This fix is good, we can fix the svg file locations later.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28134#pullrequestreview-3478734910


More information about the build-dev mailing list