RFR: 8369454: Verify checksums of downloaded source bundles when creating devkit [v2]
Mikael Vidstedt
mikael at openjdk.org
Thu Oct 9 18:09:25 UTC 2025
On Thu, 9 Oct 2025 17:14:11 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Mikael Vidstedt has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Update DownloadVerify comment
>> - Rename DownloadVerify
>> - Update make/devkit/Tools.gmk
>>
>> Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>
> make/devkit/Tools.gmk line 224:
>
>> 222:
>> 223: # Generate downloading + unpacking of sources.
>> 224: define DownloadVerifyUnpack
>
> It's not actually unpacking is it?
> Suggestion:
>
> define DownloadVerify
Updated the name and the comment to match the actual behavior
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27708#discussion_r2417574723
More information about the build-dev
mailing list