RFR: 8233115: Protect ExecuteWithLog from running with redirection without a subshell [v3]

[Magnus Ihse Bursie]

On Thu, 4 Sep 2025 16:54:27 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Break all lines to fit in 80 chars
>>  - Break long lines
>
> make/common/MakeBase.gmk line 306:
> 
>> 304:   $(call MakeDir, $(dir $(strip $1)) $(MAKESUPPORT_OUTPUTDIR)/failure-logs) \
>> 305:   $(call WriteFile, $2, $(strip $1).cmdline) \
>> 306:   ( $(RM) $(strip $1).log && $(if $(call is_redirect, $2),$(LEFT_PAREN) )$(strip $2)$(if $(call is_redirect, $2), $(RIGHT_PAREN)) > >($(TEE) -a $(strip $1).log) 2> >($(TEE) -a $(strip $1).log >&2) || \
> 
> Consider breaking these lines.

Good point. I turned all of them into 80 char max. It's both helpful and hurtful for readability, but let's stick to our standard.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27096#discussion_r2324505388