RFR: 8330341: Wrap call to MT in ExecuteWithLog
Magnus Ihse Bursie
ihse at openjdk.org
Sat Sep 6 09:15:47 UTC 2025
We should wrap the call to `mt` in `ExecuteWithLog`. I tried to do this earlier but ran into problems with the tricky command line. The solution was to use `$$(COMMA)` (and `$$(HASH)`); I'm not sure why I did not see this before.
I also notet that there is an actual bug in the MT command line -- the trailing `;#1` is not protected from the shell, so the command line will end after `-outputresource:$$@`, and then a new command -- the comment `#1` which does nothing, will be executed. This works out anyway since if you leave out the resource identifier index the value of `CREATEPROCESS_MANIFEST_RESOURCE` will be used by default, and that happens to be 1.
(See https://learn.microsoft.com/en-us/windows/win32/sbscs/mt-exe)
-------------
Commit messages:
- 8330341: Wrap call to MT in ExecuteWithLog
Changes: https://git.openjdk.org/jdk/pull/27124/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=27124&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8330341
Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/27124.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27124/head:pull/27124
PR: https://git.openjdk.org/jdk/pull/27124
More information about the build-dev
mailing list