Integrated: 8365231: Don't build gtest with /EHsc

Tue Sep 9 11:01:16 UTC 2025

On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> According to https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should not build gtest with `/EHsc`. 
> 
> I can honestly say I don't fully understand the consequences of this change, but at least it passes building and testing on Oracle CI. And it does seem to make sense that we build the gtest version of libjvm as close as possible to the real version. For libgtest I just thought it was prudent to keep the flags in sync with how we build libjvm. This might not be the correct decision.
> 
> I have not tested how or if this affects the ability for gtest to handle bugs or crashes in the JVM, nor do I really have any idea about any such consequences. This PR is opened more to start a discussion than with the intention of just integrating this.

This pull request has now been integrated.

Changeset: a25dde62
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a25dde6279c100dcff266d19b263e764f5da244e
Stats:     4 lines in 1 file changed: 1 ins; 2 del; 1 mod

8365231: Don't build gtest with /EHsc

Reviewed-by: kbarrett, stuefe

-------------

PR: https://git.openjdk.org/jdk/pull/26721