RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v6]

[SendaoYan]

On Tue, 9 Sep 2025 07:06:26 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use UTIL_ARG_ENABLE instead of AC_ARG_ENABLE
>
> make/autoconf/flags-cflags.m4 line 994:
> 
>> 992: ])
>> 993: 
>> 994: AC_DEFUN([BPERF_SETUP_SVE],
> 
> The `BPERF_` prefix says that this function belongs to build-performance.m4.

Fixed.

> make/autoconf/flags-cflags.m4 line 997:
> 
>> 995: [
>> 996:   UTIL_ARG_ENABLE(NAME: aarch64-sve, DEFAULT: auto,
>> 997:       RESULT: enable_aarch64_sve,
> 
> We use upper-case letters for everything but variables that are local to a function. A name like `AARCH64_SVE_ENABLED` would be more in line with how we usually name these variables (even if, for historical reasons, we have not been consistent with this.)
> 
> In fact, `UTIL_ARG_ENABLE` will create `AARCH64_SVE_ENABLED` for you automatically if you do not set `RESULT:`, but for clarity this is still recommended.

Thanks. Fixed.

> make/autoconf/flags-cflags.m4 line 999:
> 
>> 997:       RESULT: enable_aarch64_sve,
>> 998:       DESC: [Use SVE when compile libsleef])
>> 999:   AC_SUBST(enable_aarch64_sve)
> 
> You don't need `AC_SUBST`. You are not exporting this to spec.gmk.

Thanks for the explanation. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27073#discussion_r2336119267
PR Review Comment: https://git.openjdk.org/jdk/pull/27073#discussion_r2336120905
PR Review Comment: https://git.openjdk.org/jdk/pull/27073#discussion_r2336129218