RFR: 8366899: SetupExecute should add the command line to vardeps

Erik Joelsson erikj at openjdk.org
Wed Sep 17 19:42:35 UTC 2025


On Wed, 17 Sep 2025 15:16:58 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> If the command line changes, it is reason to re-run the command.

make/common/Execute.gmk line 153:

> 151:   $1_VARDEPS := $$($1_COMMAND) $$($1_PRE_COMMAND) $$($1_POST_COMMAND)
> 152:   $1_VARDEPS_FILE := $$(call DependOnVariable, $1_VARDEPS)
> 153:   $1_DEPS += $$($1_VARDEPS_FILE)

`$1_DEPS` is an input parameter. Should we really be appending to it inside the macro body?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27348#discussion_r2356576561


More information about the build-dev mailing list