RFR: 8366899: SetupExecute should add the command line to vardeps

[Magnus Ihse Bursie]

On Thu, 18 Sep 2025 16:42:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> I think we usually do that? I mean, if I were programming in a proper language, I'd be horrified at the thought of changing a function argument. But with the limited expressiveness of make, I think this is okay.
>> 
>> What alternative would you prefer otherwise? That we create a new `$1_EXTRA_DEPS`, add the vardeps file to it, and insert `$$($1_EXTRA_DEPS)` wherever we have `$$($1_DEPS)`? Or explicitly adding the `$$($1_VARDEPS_FILE)` everywhere instead? I don't think any of these are necessarily better.
>
> I'm not going to fight for it, but I would most likely have gone with some variant of what you suggested.

I'm not going to fight for my solution either. :) Which would you prefer, explicitly adding vardeps, or creating a new general extra-deps?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27348#discussion_r2360439782