RFR: 8368102: Don't store macros in spec.gmk
Magnus Ihse Bursie
ihse at openjdk.org
Fri Sep 19 17:12:34 UTC 2025
On Fri, 19 Sep 2025 16:43:50 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> We currently have three macros (as in "functions", not just simple strings) that are assigned in spec.gmk. This is in contrast with the rest of the values assigned in spec.gmk, and it is surprising and is forcing an odd syntax. Furthermore, these macros are named as constants, and not as we normally name functions/macros.
>
> We should move them to normal .gmk code, and rename them.
>
> The three macros are `SET_SHARED_LIBRARY_ORIGIN`, `SET_EXECUTABLE_ORIGIN` and `SET_SHARED_LIBRARY_NAME`.
It is clear that this refactoring lends itself towards even more cleanups, but I'll save that for another day.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27394#issuecomment-3312917661
More information about the build-dev
mailing list