RFR: 8368468: Split out everything but configure results from spec.gmk [v2]

[Erik Joelsson]

On Wed, 24 Sep 2025 14:54:15 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/common/CommonVars.gmk line 222:
>> 
>>> 220: 
>>> 221: # You run the new javac using the boot jdk with $(BOOT_JDK)/bin/java $(NEW_JAVAC) ...
>>> 222: # Use = assignment to be able to override in bootcycle-spec.gmk
>> 
>> This comment isn't correct anymore.
>
> There were many issues here. First of all, NEW_JAVAC is not used anymore so it is dead code. Secondly, we still need = assignment for bootcycle builds, but only for JAVADOC. But this is not technically done in bootcycle-spec.gmk anymore. 
> 
> I removed the dead code and updated the comment, hope you are okay with it.
> 
> There's a lot of cleaning work needed for this file. At this point, I just wanted to do a clear a separation as possible.

I understand that there is a lot of cleanup needed. I only pointed this out as it was a comment that was obviously becoming outdated by this change and similar comments in other places had different wordings that still worked.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27452#discussion_r2376686297