RFR: 8374754: jtreg failure handler - replace inline javascript and inline event handlers with same origin javascript files
David Holmes
dholmes at openjdk.org
Thu Jan 8 05:59:31 UTC 2026
On Thu, 8 Jan 2026 05:18:52 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change to the jtreg failure handler that we use in the JDK? As noted in https://bugs.openjdk.org/browse/JDK-8374754 this change addresses the HTML rendering issues that are noticed in certain setups. The change here moves the inline javascript to a file of its own (generated as and when necessary).
test/failure_handler/src/share/classes/jdk/test/failurehandler/HtmlPage.java line 65:
> 63: this.writer = new PrintWriter(fileWriter, true);
> 64: createScriptFile(dir);
> 65: createStyleSheetFile(dir);
Won't this create/overwrite the files each time one of the artifact pages (cores.html, processes.html etc) get created? Don't we just want to create one copy of these files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29106#discussion_r2670968504
More information about the build-dev
mailing list