RFR: 8374754: jtreg failure handler - replace inline javascript and inline event handlers with same origin javascript files [v2]

Daniel Jeliński djelinski at openjdk.org
Thu Jan 8 07:13:37 UTC 2026


On Thu, 8 Jan 2026 06:54:50 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change to the jtreg failure handler that we use in the JDK? As noted in https://bugs.openjdk.org/browse/JDK-8374754 this change addresses the HTML rendering issues that are noticed in certain setups. The change here moves the inline javascript to a file of its own (generated as and when necessary).
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   create the script and css files only if not already present

test/failure_handler/src/share/classes/jdk/test/failurehandler/HtmlPage.java line 96:

> 94:         }
> 95:         final String content = """
> 96:                 function doShow(e) {

Would it be possible to check in the css/js files to the repository instead of generating them on the fly?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29106#discussion_r2671146941


More information about the build-dev mailing list