RFR: 8367530: The exhaustiveness errors could be improved [v13]

[Maurizio Cimadamore]

On Mon, 26 Jan 2026 12:11:26 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Attempting to use the number of 'base checks' as the limit, instead of wall-clock time.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ExhaustivenessComputer.java line 691:
> 
>> 689:     }
>> 690: 
>> 691:     protected void checkTimeout() {
> 
> This is probably no longer a good name for this method.
> 
> More seriously, I have a question as to why this method is only checked (AFAICS) from `isBpCovered`. I would have expected it to be more directly tied to `computeMissingPatternDescriptions` ?

Maybe the intent is that you don't want to just check the "depth" of the check, but also the "width" -- e.g. if there's few nested record patterns, but each has a huge number of components.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27256#discussion_r2727375413