RFR: 8376274: JSpec preview support and output enhancement [v3]
Hannes Wallnöfer
hannesw at openjdk.org
Tue Jan 27 14:54:21 UTC 2026
On Tue, 27 Jan 2026 14:26:41 GMT, Chen Liang <liach at openjdk.org> wrote:
>> We can enhance the `@jls` and `@jvms` tags in-place to support preview JLS/JVMS, such as in this PR:
>>
>>
>> @jls primitive-types-in-patterns-instanceof-switch-5.7.1 Exact Testing Conversions
>>
>>
>> Taglet now parses "primitive-types-in-patterns-instanceof-switch-" preview and links to `primitive-types-in-patterns-instanceof-switch-jls.html` where the 5.7.1 anchor exists.
>>
>> As a side effect, I adjusted the output to remove the preview prefix, and discovered we can embellish the output more, in particular, including a section sign for inline tags and including a trailing dot for block tags.
>>
>> I need this feature in project Valhalla, where there are JLS and JVMS for value-objects and strict-fields that we need to link to. Please help review!
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Add preview superscript when applicable
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/jspec-enhance
> - Remove redundant dot
> - 8376274: JSpec preview support and output enhancement
Looks good to me!
-------------
Marked as reviewed by hannesw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29402#pullrequestreview-3711671933
More information about the build-dev
mailing list