<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 11/04/09 06:04 PM, Andrew John Hughes wrote:
<blockquote
cite="mid:17c6771e0911041804i4f4bf39fp82ada57945366b75@mail.gmail.com"
type="cite">
<pre wrap="">2009/11/5 Kelly O'Hair <a class="moz-txt-link-rfc2396E" href="mailto:Kelly.Ohair@sun.com"><Kelly.Ohair@sun.com></a>:
</pre>
<blockquote type="cite">
<pre wrap="">
Andrew John Hughes wrote:
</pre>
<blockquote type="cite">
<pre wrap="">2009/11/4 Kelly O'Hair <a class="moz-txt-link-rfc2396E" href="mailto:Kelly.Ohair@sun.com"><Kelly.Ohair@sun.com></a>:
</pre>
<blockquote type="cite">
<pre wrap="">Andrew John Hughes wrote:
</pre>
<blockquote type="cite">
<pre wrap="">2009/11/4 Kelly O'Hair <a class="moz-txt-link-rfc2396E" href="mailto:Kelly.Ohair@sun.com"><Kelly.Ohair@sun.com></a>:
</pre>
<blockquote type="cite">
<pre wrap="">Andrew John Hughes wrote:
</pre>
<blockquote type="cite">
<pre wrap="">2009/11/4 Kelly O'Hair <a class="moz-txt-link-rfc2396E" href="mailto:Kelly.Ohair@sun.com"><Kelly.Ohair@sun.com></a>:
</pre>
<blockquote type="cite">
<pre wrap="">I'm basically ok with this, but have one concern.
There is no longer a default ant value for drops.dir, it is only
set via the Makefile. Maybe that's ok, just not sure.
I think it means that a plain 'ant' command will always download
from the url. Again, maybe that's fine. So I'm ok with the push.
</pre>
</blockquote>
<pre wrap="">Ah I see what you mean. I changed things so all the logic was in one
place in the Makefile:
ifdef ALT_DROPS_DIR
DROPS_DIR = $(ALT_DROPS_DIR)
else
ifdef ALT_JDK_DEVTOOLS_DIR
DROPS_DIR = $(ALT_JDK_DEVTOOLS_DIR)/share/jdk7-drops
else
DROPS_DIR = $(_SLASHJAVA)/devtools/share/jdk7-drops
endif
endif
so you get the same behaviour as before, but as you say, only when
running ant via the makefile.
Is ant ever run directly in this situation? I've never had reason to
do
so.
</pre>
</blockquote>
<pre wrap="">I do manually, and if you build via the NetBeans project. But the url
usage should work.
</pre>
<blockquote type="cite">
<pre wrap="">Either way, I can add an updated version back to the build.xml.
That's not a problem, as we'll never use it.
Can you allocate a bug ID so I can push? :)
</pre>
</blockquote>
<pre wrap="">6898251: Add ALT_DROPS_DIR feature to jaxp/jaxws
-kto
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">I've learned to keep ant scripts out of the environment variable
business if at all possible, so leaving any env var logic in
the makefiles may be fine.
Keeping the ant<->make boundaries simple seems like an essential
thing to do, sigh, but is anything "simple" with ant scripts or
Makefiles... :^(
</pre>
</blockquote>
<pre wrap="">I know what you mean all too well... :(
At one point, I managed to have three different JDKs, all from
different vendors, involved in the building of langtools...
</pre>
<blockquote type="cite">
<pre wrap="">-kto
Andrew John Hughes wrote:
</pre>
<blockquote type="cite">
<pre wrap="">2009/10/28 Andrew John Hughes <a class="moz-txt-link-rfc2396E" href="mailto:gnu_andrew@member.fsf.org"><gnu_andrew@member.fsf.org></a>:
snip..
</pre>
<blockquote type="cite">
<pre wrap="">Well spotted; revised version here:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~andrew/drops/webrev.03/">http://cr.openjdk.java.net/~andrew/drops/webrev.03/</a>
</pre>
</blockquote>
<pre wrap="">Does this look ok to push?
</pre>
</blockquote>
</blockquote>
<pre wrap="">Thanks,
</pre>
</blockquote>
</blockquote>
<pre wrap="">You've probably mentioned this before, but to which tree? I have it
applied to tl here for some reason I can't now remember...
</pre>
</blockquote>
<pre wrap="">You will need to use the jdk7/tl forest.
The jdk7/build forest doesn't have the jdk7/tl jaxp/jaxws changes yet.
-kto
</pre>
</blockquote>
<pre wrap="">Thanks all.
Pushed:
<a class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/26b97fd0e595">http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/26b97fd0e595</a>
<a class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/600bc3d048be">http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/600bc3d048be</a>
</pre>
</blockquote>
<pre wrap="">Did you plan on doing this to jdk6 too?
-kto
</pre>
</blockquote>
<pre wrap=""><!---->
Yes indeed. But I think Joe wanted to get the security fixes out of
the way first.
</pre>
</blockquote>
<br>
Correct andI pre-approve keeping the JDK 7 and OpenJDK 6 jaxp/jaxws
mechanisms in sync.<br>
<br>
-Joe<br>
</body>
</html>