<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Basic change seems harmless to me, the _ARCH_ definition is a little concerning, do we need<div>that definition for all arch's or just alpha?</div><div>I hate to pollute this already overpopulated arch naming mess. :^(<br><div><br></div><div>How about:<div><br></div><div><pre><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 12px; ">CPP_ARCH_FLAGS = -DARCH='"$(ARCH)"'</span></font></pre></div><div><pre><span class="Apple-style-span" style="font-family: Courier; font-size: 12px; "># Alpha arch does not like "alpha" defined (potential general arch cleanup issue here)</span></pre><pre><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 12px;">ifneq ($(ARCH),alpha)</span></font></pre><pre><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 12px;"> CPP_ARCH_FLAGS += -D$(ARCH)</span></font></pre><pre><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 12px;">else</span></font></pre><pre><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 12px; "> CPP_ARCH_FLAGS += -D_$(ARCH)_</span></font></pre><pre><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 12px;">endif</span></font></pre><pre><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 12px;">CPPFLAGS_COMMON = $(CPP_ARCH_FLAGS) -DLINUX $(VERSION_DEFINES) \</span></font></pre><pre><font class="Apple-style-span" face="Courier" size="3"><span class="Apple-style-span" style="font-size: 12px;"> -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -D_REENTRANT
</span></font></pre><div>Just a suggestion. One of these days, the whole ARCH issue needs to be cleaned up, just not sure that will ever happen. :^(</div><div><br></div><div>Filed this bug for you.</div><div><br></div><div><div>6958257: Add support for alpha</div><div><br></div><div>-kto</div><div><br></div><div><div>On Jun 3, 2010, at 9:59 AM, Andrew John Hughes wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hi,<br><br>The webrev:<br><br><a href="http://cr.openjdk.java.net/~andrew/zero/webrev.04/">http://cr.openjdk.java.net/~andrew/zero/webrev.04/</a><br><br>extends the build changes added as part of the Zero assembler port to<br>also support the alpha architecture. This has been used in IcedTea6<br>since July 2008.<br><br>The change to ARCH is necessary so we don't get -Dalpha which<br>conflicts with the use of variables named 'alpha' in the source code.<br>ARCH is defined as before for non-alpha architectures.<br><br>Ok to push to the build forest? If so, can I have a bug ID?<br><br>Thanks,<br>-- <br>Andrew :-)<br><br>Free Java Software Engineer<br>Red Hat, Inc. (http://www.redhat.com)<br><br>Support Free Java!<br>Contribute to GNU Classpath and the OpenJDK<br>http://www.gnu.org/software/classpath<br>http://openjdk.java.net<br><br>PGP Key: 94EFD9D8 (http://subkeys.pgp.net)<br>Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8<br></div></blockquote></div><br></div></div></div></div></body></html>