<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><font class="Apple-style-span" face="Courier">The change looks fine, but I suspect that between the time you push this change, and a promoted jdk7 build is created from it,</font><div><font class="Apple-style-span" face="Courier">anyone building the jdk repository by itself will fail because the imported jdk7 image won't have these files.</font></div><div><font class="Apple-style-span" face="Courier">A bit of a catch22.</font></div><div><font class="Apple-style-span" face="Courier"><br></font></div><div><font class="Apple-style-span" face="Courier">Either the change needs to include some kind of check for existence:</font></div><div><font class="Apple-style-span" face="Courier"><br></font></div><div><font class="Apple-style-span" face="Courier">ifneq ($(wildcard </font><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Courier">$(LIB_LOCATION)/$(SERVER_LOCATION)/$(JVMDTRACE_NAME)),)</font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Courier">...</font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Courier">endif</font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Courier"><br></font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Courier">which could be removed after the promotion.</font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Courier"><br></font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Courier">Or you need to time this change so it happens very shortly before the promotion.</font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Courier"><br></font></span></div><div><font class="Apple-style-span" face="Courier">-kto</font></div><div><br><div><div>On Sep 9, 2010, at 6:24 AM, Keith McGuigan wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hello,<br><br>I'd like a code review for this change which imports the libjvm_db.so and libjvm_dtrace.so files from Hotspot into the solaris JDK images (libjvm_dtrace was missing, and libjvm_db was missing for x86).<br><br><a href="http://cr.openjdk.java.net/~kamg/6983225/webrev.00/">http://cr.openjdk.java.net/~kamg/6983225/webrev.00/</a><br><br>Thanks!<br><br>--<br>- Keith<br></div></blockquote></div><br></div></body></html>