<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 18, 2010, at 4:30 PM, David Holmes wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Kelly O'Hair said the following on 10/19/10 03:23:<br><blockquote type="cite">On Oct 17, 2010, at 10:35 PM, David Holmes wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite">I happened to notice in jdk/make/common/shared/Sanity.gmk:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">sane-gcc-compiler:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">ifeq ($(PLATFORM), solaris)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> ifndef OPENJDK<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> @if [ -r $(GCC_COMPILER_PATH) ]; then \<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> ....<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> fi<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> endif<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> ifeq ($(PLATFORM), linux)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Looks to me like there's a misplaced endif there.<br></blockquote></blockquote><blockquote type="cite">Not sure I see any misplaced endif. I looked at <a href="http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/0613978371d8/make/common/shared/Sanity.gmk">http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/0613978371d8/make/common/shared/Sanity.gmk</a> <br></blockquote><br>You need an endif before the "ifeq ($(PLATFORM), linux)". Last time I checked the platform can't be both solaris and linux so the current arrangement has a heap of "dead code" in it.<br></div></blockquote><div><br></div><div>I think all the endif' are there, but these lines need to be swapped:</div><div style="font-family: monospace;" class="parity1"><pre><span class="linenr"> 1482</span> ifeq ($(PLATFORM), solaris)
</pre></div><div style="font-family: monospace;" class="parity0"><pre><span class="linenr"> 1483</span> ifndef OPENJDK
</pre><pre>This entire sanity check was meant for building the plugin with a very old gcc, and none of it</pre><pre>applies to the OPENJDK builds.</pre><pre><br></pre><pre>-kto</pre><pre><br></pre></div><blockquote type="cite"><div><br>David<br><br><blockquote type="cite">I do see a rather ugly improperly indented mix of shell if commands and makefile if statements. :^(<br></blockquote><blockquote type="cite">Or maybe the bad indenting is the TAB character viewing problem. :^(<br></blockquote><blockquote type="cite">-kto<br></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">David<br></blockquote></blockquote></div></blockquote></div><br></body></html>