<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Kelly,<br>
<br>
Logic looks fine, just a nit<br>
<br>
Unless <span class="changed">$(NONFCS_BUILD_INFO)</span>
really needs that leading "-", I'd remove it and add a "-" in line
110 and 297 below. Makes it a bit more readable<br>
<br>
Dave<br>
<h2>hotspot/make/defs.make</h2>
<blockquote type="cite">
<pre> 109 else
<span class="changed"> 110 HOTSPOT_BUILD_VERSION=internal$(NONFCS_BUILD_INFO)</span>
111 endif
</pre>
</blockquote>
<br>
<h2>jdk/make/common/shared/Defs.gmk</h2>
<blockquote type="cite">
<pre><span class="new">290 ifndef NONFCS_BUILD_INFO</span>
291 BUILD_DATE := $(shell $(DATE) '+%Y_%m_%d_%H_%M')
292 CLEAN_USERNAME := $(shell $(ECHO) "$(USER)" | $(TR) -d -c '[:alnum:]')
293 USER_RELEASE_SUFFIX := $(shell $(ECHO) "$(CLEAN_USERNAME)_$(BUILD_DATE)" | $(TR) '[:upper:]' '[:lower:]' )
<span class="changed"> 294 NONFCS_BUILD_INFO = -$(USER_RELEASE_SUFFIX)</span>
<span class="changed"> 295 endif</span>
<span class="changed"> 296 export NONFCS_BUILD_INFO</span>
<span class="changed"> 297 FULL_VERSION = $(RELEASE)$(NONFCS_BUILD_INFO)-$(BUILD_NUMBER)</span>
298 endif
</pre>
</blockquote>
<br>
<br>
<br>
<br>
On 11/24/2010 11:36 AM, Kelly O'Hair wrote:
<blockquote
cite="mid:CDC1659F-04F7-4E30-8D56-E19DE83D4A64@oracle.com"
type="cite">Dang... just shoot me now. :^(
<br>
<br>
Try this:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/">http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/</a>
<br>
<br>
Sorry about that.
<br>
<br>
-kto
<br>
<br>
On Nov 24, 2010, at 11:28 AM, Mark Wielaard wrote:
<br>
<br>
<blockquote type="cite">On Wed, 2010-11-24 at 11:19 -0800, Kelly
O'Hair wrote:
<br>
<blockquote type="cite">I need a reviewer for this change:
<br>
<br>
6987107: Add NONFCS_BUILD_INFO variable to add to but not
modify
<br>
MILESTONE in version string
<br>
<a class="moz-txt-link-freetext" href="http://javaweb.sfbay.sun.com/~ohair/webrevs/jdk7/nonfcs-version/webrev/">http://javaweb.sfbay.sun.com/~ohair/webrevs/jdk7/nonfcs-version/webrev/</a>
<br>
</blockquote>
<br>
Bit hard to review if the host isn't reachable :)
<br>
Could you just attach the patch to your email,
<br>
or post it on some publicly reachable machine?
<br>
<br>
Thanks,
<br>
<br>
Mark
<br>
<br>
</blockquote>
<br>
</blockquote>
</body>
</html>