<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><span class="Apple-style-span" style="font-family: monospace; ">Need reviewer: Misc fixes related to binary file checks</span></div><div><span class="Apple-style-span" style="font-family: monospace; "><br></span><span class="Apple-style-span" style="font-family: monospace; ">This started out as fixing a rebase bug but we also needed to verify that our libraries were</span><span class="Apple-style-span" style="font-family: monospace; "><br></span><span class="Apple-style-span" style="font-family: monospace; ">built properly, so the binary_file_verification define was created to do this.</span></div><div><span class="Apple-style-span" style="font-family: monospace; "></span><span class="Apple-style-span" style="font-family: monospace; ">The checks are not nailed down yet, but I need to get the calls to the binary_file_verification</span></div><div><span class="Apple-style-span" style="font-family: monospace; ">define in place first.<br></span><span class="Apple-style-span" style="font-family: monospace; "><br></span><span class="Apple-style-span" style="font-family: monospace; ">Initially the plan was to do this check when the j2sdk-image was created, but it seemed to make</span><span class="Apple-style-span" style="font-family: monospace; "><br></span><span class="Apple-style-span" style="font-family: monospace; ">sense to verify the binaries where they are created and as they get imported in so we can catch</span><span class="Apple-style-span" style="font-family: monospace; "><br></span><span class="Apple-style-span" style="font-family: monospace; ">problem binaries as soon as possible.</span><span class="Apple-style-span" style="font-family: monospace; "><br></span><span class="Apple-style-span" style="font-family: monospace; "></span><span class="Apple-style-span" style="font-family: monospace; "><br></span><span class="Apple-style-span" style="font-family: monospace; ">6413588: Add 'ldd -r' and 'dump -Lv' checks to all .so files delivered in the JDK</span><span class="Apple-style-span" style="font-family: monospace; "><br></span><span class="Apple-style-span" style="font-family: monospace; ">6975326: Problem in install/make/rebase/Makefile, grep on empty pattern</span><span class="Apple-style-span" style="font-family: monospace; "><br></span><span class="Apple-style-span" style="font-family: monospace; ">7000995: Add check in makefiles to verify that msvcp100.dll is NOT used</span></div><div><span class="Apple-style-span" style="font-family: monospace; "><br></span></div><div><span class="Apple-style-span" style="font-family: monospace; "><a href="http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-binary_file_verification/webrev/">http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-binary_file_verification/webrev/</a><font class="Apple-style-span" color="#144FAE"><u><br></u></font></span></div><div><span class="Apple-style-span" style="font-family: monospace; "><br></span></div><div><span class="Apple-style-span" style="font-family: monospace; ">On Windows we currently want to make sure the DLL can have a Dynamic base, and that it</span></div><div><span class="Apple-style-span" style="font-family: monospace; ">is NX compatible (DEP).</span></div><div><span class="Apple-style-span" style="font-family: monospace; ">On Solaris and Linux, there is mostly just runs of ldd, nm, and dump/readobj, the specific</span></div><div><span class="Apple-style-span" style="font-family: monospace; ">things we want to check for may take a little more time to nail down.</span></div><div><span class="Apple-style-span" style="font-family: monospace; ">This binary_file_verification also provides some details in the build log with regards</span></div><div><span class="Apple-style-span" style="font-family: monospace; ">to the library dependencies, which may be of use someday in tracking down dependency issues.</span></div><div><span class="Apple-style-span" style="font-family: monospace; "><br></span></div><div><span class="Apple-style-span" style="font-family: monospace; ">-kto</span></div></body></html>