<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Looks ok to me.<div><br></div><div>-kto</div><div><br><div><div>On Mar 24, 2011, at 7:08 PM, Jonathan Gibbons wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<div bgcolor="#ffffff" text="#000000">
<font face="DejaVu Serif">I need a build-dev reviewer for this
patch.<br>
<br>
This is a simple patch to langtools/make/build.xml to stop
inappropriate files getting into tools.jar.<br>
<br>
</font><font face="DejaVu Serif">
<blockquote type="cite"><tt>diff -r 83260b3305ac make/build.xml<br>
--- a/make/build.xml Thu Mar 24 16:14:30 2011 -0700<br>
+++ b/make/build.xml Thu Mar 24 19:00:16 2011 -0700<br>
@@ -806,6 +806,9 @@<br>
<exclude name="**/*.java"/><br>
<exclude
name="**/*.properties"/><br>
<exclude name="**/*-template"/><br>
+ <exclude name="**/*.rej"/><br>
+ <exclude name="**/*.orig"/><br>
+ <exclude
name="**/overview.html"/><br>
<exclude
name="**/package.html"/><br>
</fileset><br>
</copy></tt><br>
</blockquote>
<br>
The first two lines (*.rej, *.orig) are primarily for the benefit
of developers and developer builds, since official builds never
contain such files. The last line (overview.html) is needed for
all builds to prevent a couple of such files making it all the way
into tools.jar. (Oops.)<br>
<br>
Tested by comparing the list of contents of tools.jar before/after
the fix, and since overview.html is involved as well, verified
that the generated docs are unaffected (specifically for the
Mirror API.)<br>
<br>
-- Jon <br>
</font>
</div>
</blockquote></div><br></div></body></html>