<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 6, 2011, at 6:07 AM, Daniel D. Daugherty wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<div bgcolor="#ffffff" text="#000000">
On 4/5/2011 9:35 PM, Kelly O'Hair wrote:
<blockquote cite="mid:9437A5F1-ACE2-4DC0-8C41-723248257D45@oracle.com" type="cite"><br>
<div>
<div>On Apr 5, 2011, at 8:30 PM, Daniel D. Daugherty wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div bgcolor="#ffffff" text="#000000"><tt>Looks good to me also. :-)<br>
<br>
Dan<br>
<br>
P.S.<br>
So the missing "endif" at the end didn't cause any errors?<br>
</tt></div>
</blockquote>
<div><br>
</div>
Before I changed the files, they ended with "endif" and no newline, I
just added a newline at the end</div>
</blockquote>
<tt><br>
So the "frames" version of the webrev has a bug and doesn't<br>
show the "endif" on the left side because it is missing the<br>
newline. Interesting...<br>
<br>
"cdiffs" and "udiffs" have it right. "sdiffs" is also wrong.<br></tt></div></blockquote><div><br></div>Yup.</div><div><br></div><div>The jcheck extension would have caught this problem in java/c/c++ source, but it doesn't</div><div>inspect makefiles, hard for it to know what is a makefile and what isn't, and if course we need those</div><div>tabs. ;^)</div><div><br></div><div>-kto</div><div><br><blockquote type="cite"><div bgcolor="#ffffff" text="#000000"><tt>
<br>
Dan<br>
<br>
<br>
</tt>
<blockquote cite="mid:9437A5F1-ACE2-4DC0-8C41-723248257D45@oracle.com" type="cite">
<div><br>
</div>
<div>-kto</div>
<div><br>
<blockquote type="cite">
<div bgcolor="#ffffff" text="#000000"><tt><br>
</tt><br>
On 4/5/2011 6:29 PM, Kelly O'Hair wrote:
<blockquote cite="mid:F5C3DDD2-2286-440D-9432-A7B52ED20D5C@oracle.com" type="cite">
<pre wrap="">Sorry... I put dcubed down as the reviewer and meant to put dholmes. :^(
It's been a long day... :^( Need to go home and get some sleep.
Thank you for the review, you too Dan. ;^)
-kto
On Apr 5, 2011, at 5:17 PM, David Holmes wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Looks good to me.
David
Kelly O'Hair said the following on 04/06/11 09:53:
</pre>
<blockquote type="cite">
<pre wrap="">Strange... I need a reviewer on this small change.... not sure why my email never showed up. :^(
Begin forwarded message:
</pre>
<blockquote type="cite">
<pre wrap="">*From: *Kelly O'Hair <<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:kelly.ohair@oracle.com">kelly.ohair@oracle.com</a> <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:kelly.ohair@oracle.com"><mailto:kelly.ohair@oracle.com></a>>
*Date: *April 5, 2011 11:56:25 AM PDT
*To: *build-dev <<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a> <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:build-dev@openjdk.java.net"><mailto:build-dev@openjdk.java.net></a>>
*Subject: **Need reviewer: Turn off warnings for mapfiles in fastdebug builds*
Need reviewer: Turn off warnings for mapfiles in fastdebug builds
The mapfiles are generally not used on fastdebug or debug builds, this just turns off the
warning in these cases, making it just an informative piece of information.
7033960: Do not check for mapfiles when fastdebug building
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-build-mapfile-warning/webrev/">http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-mapfile-warning/webrev/</a>
-kto
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap=""><!---->
</pre>
</blockquote>
</div>
</blockquote>
</div>
<br>
</blockquote>
</div>
</blockquote></div><br></body></html>