<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Kelly,<div><br></div><div>Thanks for reviewing and providing the suggestion. I've tested with the suggested codes and updated the webrev.</div><div><br></div><div>Regards,</div><div>Su-Chen<br><div><div>On Apr 12, 2011, at 4:47 PM, Kelly O'Hair wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div>I think we have a problem with this, I've looked at this before, but something is wrong here.<div>The end result could be a negative number if the max memory was say, 256Mb RAM, and</div><div>0 if the machine has 512Mb of RAM.<br><div><br></div><div>I'm thinking that this:</div><div><pre> 443 MAX_VM_MEMORY := $(shell \
444 if [ $(MB_OF_MEMORY) -le 1024 ] ; then \
<span class="changed"> 445 expr $(MB_OF_MEMORY) '-' 512 2> $(DEV_NULL) ; \</span>
446 else \
<span class="changed"> 447 echo "512"; \</span>
448 fi)</pre></div><div>Should just be:</div><div><pre> 443 MAX_VM_MEMORY := 512</pre><pre><br></pre><pre>To avoid a negative or 0 result. And we should delete all the comments about subtracting.</pre><pre>Any machine doing a build with less than 512Mb is very very questionable.</pre></div><div>-kto</div><div><br><div><div>On Apr 12, 2011, at 4:29 PM, <a href="mailto:SUCHEN.CHIEN@ORACLE.COM">SUCHEN.CHIEN@ORACLE.COM</a> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><pre wrap="on" style="word-wrap: break-word; "><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; ">Need Reviewer: change MAX_VM_MEMORY to 512</span></font></pre><pre wrap="on" style="white-space: pre-wrap; word-wrap: break-word; "><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px;">Windows systems may not be able to handle 896 max memory on every java app started up. Depends on what the system is running, even on a 2Gb system.
Recommend lowering the 896 to 640 or maybe even 512 if possible.</span></font></pre></div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Helvetica; ">6903609: Max memory of 896 may be too large for typical windows developer environment</div></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Helvetica; "><a href="http://cr.openjdk.java.net/~schien/CR6903609/webrev/">http://cr.openjdk.java.net/~schien/CR6903609/webrev/</a></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Helvetica; "><br></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Helvetica; "><br></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Helvetica; ">Su-Chen</div></div></blockquote></div><br></div></div></div></blockquote></div><br></div></body></html>