<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#ffffff" text="#000000">
    Hi Suchen,<br>
    <br>
    It looks good! thanks for making this change.<br>
    <br>
    Kumar<br>
    <br>
    <blockquote
      cite="mid:234F35D0-4C43-4AF9-9EE7-0AE22CD89011@oracle.com"
      type="cite">
      <div>Hi Kumar,</div>
      <div><br>
      </div>
      <div>Thanks again for the review and suggestion.  I've updated the
        code, ran test builds on all platforms and update the webrev:</div>
      <div><br>
      </div>
      <div>
        <div>
          <div><a moz-do-not-send="true"
              href="http://cr.openjdk.java.net/%7Eschien/CR6903609/webrev/">http://cr.openjdk.java.net/~schien/CR6903609/webrev/</a></div>
          <div><br>
          </div>
          <div>Regards,</div>
          <div>Su-Chen</div>
          <div><br>
          </div>
          <div>On Apr 15, 2011, at 9:39 AM, Kumar Srinivasan wrote:</div>
          <br class="Apple-interchange-newline">
          <blockquote type="cite">
            <div>
              <div style="font-family: 'Times New Roman'; font-size:
                12pt; color: rgb(0, 0, 0);">Hi,<br>
                <br>
                Sorry if I am jumping in late, but if we are hard-coding
                MAX_VM_MEMORY to 512,<br>
                the logic just below sets MIN_VM_MEMORY and it checks if
                it is 128 etc. etc.<br>
                <br>
                Why not set MIN_VM_MEMORY = MAX_VM_MEMORY and remove<br>
                all that logic, this will simplify things<span
                  class="Apple-converted-space"> </span><br>
                OR<br>
                simply allow the VM to start with its minimum heap and
                allow it to resize when the<span
                  class="Apple-converted-space"> </span><br>
                demand actually arises.<br>
                <br>
                Kumar<br>
                <br>
                -----<span class="Apple-converted-space"> </span><a
                  moz-do-not-send="true"
                  href="mailto:SUCHEN.CHIEN@oracle.com">SUCHEN.CHIEN@oracle.com</a><span
                  class="Apple-converted-space"> </span>wrote:<span
                  class="Apple-converted-space"> </span><br>
                > From:<span class="Apple-converted-space"> </span><a
                  moz-do-not-send="true"
                  href="mailto:SUCHEN.CHIEN@oracle.com">SUCHEN.CHIEN@oracle.com</a><br>
                > To:<span class="Apple-converted-space"> </span><a
                  moz-do-not-send="true"
                  href="mailto:kelly.ohair@oracle.com">kelly.ohair@oracle.com</a><br>
                > Cc:<span class="Apple-converted-space"> </span><a
                  moz-do-not-send="true"
                  href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>,<span
                  class="Apple-converted-space"> </span><a
                  moz-do-not-send="true"
                  href="mailto:david.katleman@oracle.com">david.katleman@oracle.com</a><br>
                > Sent: Friday, April 15, 2011 9:17:15 AM GMT -08:00
                US/Canada Pacific<br>
                > Subject: Re: Need Reviewer: change MAX_VM_MEMORY to
                512<br>
                ><br>
                >
                <div style="word-wrap: break-word;">> Hi Kelly,
                  <div><br>
                    ></div>
                  <div>Thanks for reviewing and providing the
                    suggestion.  I've tested with the suggested codes
                    and updated the webrev.</div>
                  <div><br>
                    ></div>
                  <div>Regards,</div>
                  <div>Su-Chen<br>
                    >
                    <div>
                      <div>On Apr 12, 2011, at 4:47 PM, Kelly O'Hair
                        wrote:</div>
                      <br class="Apple-interchange-newline">
                      <blockquote>
                        <div style="word-wrap: break-word;">>
                          <div><br>
                            ></div>
                          I think we have a problem with this, I've
                          looked at this before, but something is wrong
                          here.
                          <div>The end result could be a negative number
                            if the max memory was say, 256Mb RAM, and</div>
                          <div>0 if the machine has 512Mb of RAM.<br>
                            >
                            <div><br>
                              ></div>
                            <div>I'm thinking that this:</div>
                            <div>
                              <pre> 443     MAX_VM_MEMORY := $(shell \
 444       if [ $(MB_OF_MEMORY) -le 1024 ] ; then \
<span class="changed"> 445         expr $(MB_OF_MEMORY) '-' 512 2> $(DEV_NULL) ; \</span>
 446       else \
<span class="changed"> 447         echo "512"; \</span>
 448       fi)</pre>
                            </div>
                            <div>Should just be:</div>
                            <div>
                              <pre> 443     MAX_VM_MEMORY := 512</pre>
                              <pre>
> </pre>
                              <pre>To avoid a negative or 0 result. And we should delete all the comments about subtracting.</pre>
                              <pre>Any machine doing a build with less than 512Mb is very very questionable.</pre>
                            </div>
                            <div>-kto</div>
                            <div><br>
                              >
                              <div>
                                <div>On Apr 12, 2011, at 4:29 PM,<span
                                    class="Apple-converted-space"> </span><a
                                    moz-do-not-send="true"
                                    href="mailto:SUCHEN.CHIEN@ORACLE.COM"
                                    target="_blank">SUCHEN.CHIEN@ORACLE.COM</a><span
                                    class="Apple-converted-space"> </span>wrote:</div>
                                <br class="Apple-interchange-newline">
                                <blockquote>
                                  <div style="word-wrap: break-word;">>
                                    <div>
                                      <pre style="word-wrap: break-word;"><font class="Apple-style-span" size="3" face="Helvetica"><span class="Apple-style-span" style="font-size: 12px;">Need Reviewer: change MAX_VM_MEMORY to 512</span></font></pre>
                                      <pre style="white-space: pre-wrap; word-wrap: break-word;"><font class="Apple-style-span" size="3" face="Helvetica"><span class="Apple-style-span" style="font-size: 12px;">Windows systems may not be able to handle 896 max memory on every java app started up. Depends on what the system is running, even on a 2Gb system.

Recommend lowering the 896 to 640 or maybe even 512 if possible.</span></font></pre>
                                    </div>
                                    <div><br>
                                      ></div>
                                    <div>
                                      <div style="margin: 0px; font:
                                        12px Helvetica;">> 6903609:
                                        Max memory of 896 may be too
                                        large for typical windows
                                        developer environment</div>
                                    </div>
                                    <div style="margin: 0px; font: 12px
                                      Helvetica;">><span
                                        class="Apple-converted-space"> </span><a
                                        moz-do-not-send="true"
                                        href="http://cr.openjdk.java.net/%7Eschien/CR6903609/webrev/"
                                        target="_blank">http://cr.openjdk.java.net/~schien/CR6903609/webrev/</a></div>
                                    <div style="margin: 0px; font: 12px
                                      Helvetica;">><span
                                        class="Apple-converted-space"> </span><br>
                                      ></div>
                                    <div style="margin: 0px; font: 12px
                                      Helvetica;">><span
                                        class="Apple-converted-space"> </span><br>
                                      ></div>
                                    <div style="margin: 0px; font: 12px
                                      Helvetica;">> Su-Chen</div>
                                  </div>
                                </blockquote>
                              </div>
                              <br>
                              ></div>
                          </div>
                        </div>
                      </blockquote>
                    </div>
                    <br>
                    ></div>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </body>
</html>