<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 22, 2011, at 5:09 PM, David Katleman wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div bgcolor="#ffffff" text="#000000">
<br>
<br>
On 7/22/2011 4:57 PM, Kelly O'Hair wrote:
<blockquote cite="mid:D5DED062-642F-44FF-80B6-D6000765BD6C@oracle.com" type="cite">
<div>Can one of you review these jprt changes, there is no impact
to RE or manual developer building.</div>
<div><br>
</div>
<div>These changes are needed to instruct our internal developer
build system JPRT on how to build jdk8.</div>
<div><br>
</div>
<div><span class="Apple-style-span" style="font-family:
monospace;">7069993</span><span class="Apple-style-span" style="font-family: monospace;">: Adjust make/jprt.properties
file for jdk8</span><span class="Apple-style-span" style="font-family: monospace;"><br>
</span></div>
<div><font class="Apple-style-span" face="monospace"><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Eohair/openjdk8/jprt-changes/webrev/">http://cr.openjdk.java.net/~ohair/openjdk8/jprt-changes/webrev/</a></font></div>
</blockquote>
<br>
Couldn't see any problems with the changes.<br>
<br>
<blockquote type="cite">
<pre><span class="new"> 34 # Standard list of jprt build targets for this source tree</span>
<span class="new"> 35 jprt.build.targets= \</span>
<span class="new"> 36 solaris_sparc_5.10-{product|fastdebug}, \</span>
<span class="new"> 37 solaris_sparcv9_5.10-{product|fastdebug}, \</span>
<span class="new"> 38 solaris_i586_5.10-{product|fastdebug}, \</span>
<span class="new"> 39 solaris_x64_5.10-{product|fastdebug}, \</span>
<span class="new"> 40 linux_i586_2.6-{product|fastdebug}, \</span>
<span class="new"> 41 linux_x64_2.6-{product|fastdebug}, \</span>
<span class="new"> 42 windows_i586_5.1-{product|fastdebug}, \</span>
<span class="new"> 43 windows_x64_5.2-{product|fastdebug</span></pre>
</blockquote>
Shame there isn't a way to have the above included instead of
repeated everywhere.<br></div></blockquote><div><br></div>Yeah, this may change when we start building more platforms in jdk8, embedded and also bsd and mac</div><div>builds might be done. But we aren't quite ready for that yet, so the best thing was to explicitly list the</div><div>ones that build now.</div><div><br></div><div>-kto</div><div><br><blockquote type="cite"><div bgcolor="#ffffff" text="#000000">
<br>
Consider the code reviewed!<br>
<br>
Dave<br>
<br>
<br>
</div>
</blockquote></div><br></body></html>