<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
No progress been made. Any reason should be resolved right away?<br>
<br>
Thanks,<br>
<br>
-Zhengyu<br>
<br>
On 9/15/2011 2:50 AM, Sean Chou wrote:
<blockquote
cite="mid:CAOo=rxVhrMBZDjc5x+WxSJMa2cGYjuT5nvA6xdcv0ASzc8+z9g@mail.gmail.com"
type="cite">Hi,
<div> About this bug, is there any progressing ? </div>
<div><br>
<br>
<div class="gmail_quote">2011/6/8 Zhengyu Gu <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:zhengyu.gu@oracle.com">zhengyu.gu@oracle.com</a>></span><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
No, I did not make any progress on 6988099, as it was
deferred to JDK8. With Dan's comment, looks good to me.<br>
<br>
Thanks,<br>
<font color="#888888">
<br>
-Zhengyu</font>
<div>
<div class="h5"><br>
<br>
On 6/7/2011 12:10 PM, Daniel D. Daugherty wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Adding Zhengyu since he is the RE on 6988099 and I'm
not sure<br>
if he is on the serviceability-dev alias...<br>
<br>
Zhengyu, I don't know if you have a fix already in
process for<br>
this issue or not.<br>
<br>
Comments on the Makefile change below.<br>
<br>
<br>
Dan<br>
<br>
On 6/6/2011 8:59 PM, David Holmes wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt 0.8ex; border-left: 1px solid rgb(204, 204,
204); padding-left: 1ex;">
Sean,<br>
<br>
Because this is a JVMTI demo it falls under
serviceability, so I've cc'ed that list.<br>
<br>
David<br>
<br>
Sean Chou said the following on 06/07/11 12:18:<br>
<blockquote class="gmail_quote" style="margin: 0pt
0pt 0pt 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;">
<br>
Is there any comment ?<br>
<br>
2011/5/26 Sean Chou <<a moz-do-not-send="true"
href="mailto:zhouyx@linux.vnet.ibm.com"
target="_blank">zhouyx@linux.vnet.ibm.com</a>
<mailto:<a moz-do-not-send="true"
href="mailto:zhouyx@linux.vnet.ibm.com"
target="_blank">zhouyx@linux.vnet.ibm.com</a>>><br>
<br>
Hi all,<br>
<br>
I made a simple patch for bug<br>
<a moz-do-not-send="true"
href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6988099"
target="_blank">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6988099</a>
(jvmti demos missing Publisher (COMPANY
resource) in dll and exe<br>
files on windows) . Will anyone have a
look at my patch ? Thanks.<br>
<br>
<br>
diff --git make/common/Demo.gmk
make/common/Demo.gmk<br>
index a3788ae..8c43cf9 100644<br>
--- make/common/Demo.gmk<br>
+++ make/common/Demo.gmk<br>
@@ -158,6 +158,7 @@ ifneq ($(strip
$(DEMO_ALL_NATIVE_SOURCES)),)<br>
# bit between them.<br>
LINK.demo = $(LINK.c)<br>
LDLIBS.demo = $(EXTRA_LIBS)
$(LFLAGS_$(COMPILER_VERSION))<br>
+ DEMO_VERSION_INFO =
$(OBJDIR)/$(LIBRARY).res<br>
else<br>
ifneq ($(DEMO_NEEDS_CPP),)<br>
LINK.demo = $(LINK.cpp)<br>
@@ -288,6 +289,13 @@ ifndef DEMO_SKIP_SRCZIP<br>
$(install-file)<br>
endif<br>
</blockquote>
</blockquote>
<br>
The change below is not bracketed by "ifeq
($(PLATFORM),windows)"<br>
but it certainly looks Windows specific.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt 0.8ex; border-left: 1px solid rgb(204, 204,
204); padding-left: 1ex;">
<blockquote class="gmail_quote" style="margin: 0pt
0pt 0pt 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;"> +# JDK
name required here<br>
+RC_FLAGS += /D "JDK_FNAME=$(LIBRARY).dll" \<br>
+ /D "JDK_INTERNAL_NAME=$(LIBRARY)"
\<br>
+ /D "JDK_FTYPE=0x2L"<br>
+<br>
+<br>
+<br>
# Native library building<br>
ifdef DEMO_LIBRARY<br>
@@ -308,8 +316,11 @@
$(OBJDIR)/%.$(OBJECT_SUFFIX):
$(DEMO_BUILD_SRCDIR)/%.cpp<br>
# Actual creation of the native shared
library (C++ and C are different)<br>
$(DEMO_LIBRARY): $(DEMO_FULL_OBJECTS)<br>
@$(prep-target)<br>
+ ifeq ($(PLATFORM),windows)<br>
+ $(RC) $(RC_FLAGS)
$(CC_OBJECT_OUTPUT_FLAG)$(DEMO_VERSION_INFO)
$(VERSIONINFO_RESOURCE)<br>
+ endif<br>
$(LINK.demo) $(SHARED_LIBRARY_FLAG)
$(CC_PROGRAM_OUTPUT_FLAG)$@ \<br>
- $(DEMO_FULL_OBJECTS) $(LDLIBS.demo)<br>
+ $(DEMO_FULL_OBJECTS) $(LDLIBS.demo)
$(DEMO_VERSION_INFO)<br>
</blockquote>
</blockquote>
<br>
The above change uses "$(DEMO_VERSION_INFO)" but that
variable is<br>
only set under "ifeq ($(PLATFORM),windows)" above.
That won't break<br>
make, but I wanted to be sure that was intentional.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt 0.8ex; border-left: 1px solid rgb(204, 204,
204); padding-left: 1ex;">
<blockquote class="gmail_quote" style="margin: 0pt
0pt 0pt 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;"> @$(call
binary_file_verification,$@)<br>
# Generation of any javah include file,
make sure objects are dependent on it<br>
<br>
<br>
<br>
-- Best Regards,<br>
Sean Chou<br>
<br>
<br>
<br>
<br>
-- <br>
Best Regards,<br>
Sean Chou<br>
<br>
</blockquote>
</blockquote>
</blockquote>
<br>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
Best Regards,<br>
Sean Chou<br>
<br>
</div>
</blockquote>
</body>
</html>