Hi all,<div><br></div><div>   Would anyone like to review this patch ? The problem it trying to fix is very simple, just</div><div>add the version information to the dll files in demo.</div><div><br></div><div>   The bug link is: <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6988099">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6988099</a></div>
<div><span class="Apple-style-span" style="background-color: rgb(255, 255, 255); ">   The webrev is: <a href="http://cr.openjdk.java.net/~ngmr/6988099/webrev.00" target="_blank" style="font-family: arial, sans-serif; font-size: 13px; color: rgb(0, 0, 204); ">http://cr.openjdk.java.net/~ngmr/6988099/webrev.00</a></span><br>
<br><div class="gmail_quote">On Fri, Sep 30, 2011 at 9:28 PM, Zhengyu Gu <span dir="ltr"><<a href="mailto:zhengyu.gu@oracle.com">zhengyu.gu@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<u></u>

  
    
  
  <div bgcolor="#ffffff" text="#000000">
    Hi All,<br>
    <br>
    Could you please help with code review? After that, I can help to
    push to jdk8.<br>
    <br>
    Thanks,<br>
    <br>
    -Zhengyu<br>
    <br>
    On 9/19/2011 2:43 AM, Sean Chou wrote:
    <blockquote type="cite">Thanks to Gu and Neil. <br>
      <br>
      <div class="gmail_quote">2011/9/16 Zhengyu Gu <span dir="ltr"><<a href="mailto:zhengyu.gu@oracle.com" target="_blank">zhengyu.gu@oracle.com</a>></span><br>
        <blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
          Okay, once review is completed, I would help you to push to
          jdk8.<br>
          <br>
          Thanks,<br>
          <font color="#888888">
            <br>
            -Zhengyu</font>
          <div>
            <div><br>
              <br>
              On 9/15/2011 2:51 PM, Neil Richards wrote:<br>
              <blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
                On Thu, 2011-09-15 at 12:14 -0400, Zhengyu Gu wrote:<br>
                <blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
                  No progress been made. Any reason should be resolved
                  right away?<br>
                  <br>
                  Thanks,<br>
                  <br>
                  -Zhengyu<br>
                  <br>
                  On 9/15/2011 2:50 AM, Sean Chou wrote:<br>
                  <blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
                    Hi,<br>
                        About this bug, is there any progressing ?<br>
                    <br>
                    <br>
                    2011/6/8 Zhengyu Gu<<a href="mailto:zhengyu.gu@oracle.com" target="_blank">zhengyu.gu@oracle.com</a>><br>
                            No, I did not make any progress on 6988099,
                    as it was<br>
                            deferred to JDK8. With Dan's comment, looks
                    good to me.<br>
                    <br>
                            Thanks,<br>
                    <br>
                            -Zhengyu<br>
                  </blockquote>
                </blockquote>
                I've made a couple of modifications to Sean's suggested
                change, in<br>
                response to Dan's comments:<br>
                <br>
                      * For Windows, added '$(DEMO_VERSION_INFO)' to
                'LDLIBS.demo', so<br>
                        that the line of the link command doesn't need
                to be modified,<br>
                        and so 'DEMO_VERSION_INFO' isn't used outside a
                windows-specific<br>
                        context.<br>
                      * Wrapped the definition of 'RC_FLAGS' in a
                windows-specific<br>
                        block.<br>
                <br>
                I've uploaded the resulting webrev for your review and
                blessing [1].<br>
                <br>
                If you're happy with change, I'll look to commit it up
                into<br>
                jdk8/build/jdk<br>
                <br>
                Regards, Neil<br>
                <br>
                [1] <a href="http://cr.openjdk.java.net/%7Engmr/6988099/webrev.00" target="_blank">http://cr.openjdk.java.net/~ngmr/6988099/webrev.00</a><br>
                <br>
              </blockquote>
            </div>
          </div>
        </blockquote>
      </div>
      <br>
      <br clear="all">
      <div><br>
      </div>
      -- <br>
      Best Regards,<br>
      Sean Chou<br>
      <br>
    </blockquote>
  </div>

</blockquote></div><br><br clear="all"><div><br></div>-- <br>Best Regards,<br>Sean Chou<br><br>
</div>