<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-western">Hi,
<br>
<br>
<a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Emichaelm/7142950/jdk/webrev.2/">http://cr.openjdk.java.net/~michaelm/7142950/jdk/webrev.2/</a>
<br>
<br>
This is an updated webrev based on the contribution/suggestion
from Scott Kovatch.
<br>
It changes the build image directories on Mac, to have the same
format/directory structure
<br>
as the other platforms (ie. it removes the Contents/Home stuff).
That directory structure
<br>
required by Mac bundles is now generated in specific bundle
directories and these
<br>
are used by the install. A consequence of this change is that
anyone who has adjusted
<br>
scripts that used the built j2sdk-image, or j2re-image to know
about the mac specific paths will have to change
<br>
that back again.
<br>
<br>
This version of the change is almost agnostic on the "os.arch"
setting. The only dependency
<br>
is on 'src/macosx/bin/amd64/jvm.cfg'. That will have to be renamed
to x86_64/jvm.cfg
<br>
when 'os.arch' is changed. No other change is required.
<br>
<br>
With this change, jdk only, and incremental builds should work
again.
<br>
If you are using the previous output from a control build as
bootstrap or import jdk
<br>
for a subsequent jdk only build, then it is possible you could run
into the build problem
<br>
described in 6967648. The workaround is to rename the top-level
build directory to some
<br>
other name before doing the jdk build.
<br>
<br>
Thanks,
<br>
Michael
<br>
<br>
<br>
On 06/02/12 23:21, Scott Kovatch wrote:
<br>
<blockquote type="cite" style="color: rgb(0, 0, 0);">On Feb 6,
2012, at 2:31 PM, Michael McMahon wrote:
<br>
<br>
<blockquote type="cite" style="color: rgb(0, 0, 0);">There are a
few problems with the Mac build at the moment.
<br>
<br>
1. If SKIP_BOOT_CYCLE=false then the build fails, due to two
problems:-
<br>
1) top level Makefile doesn't know about Mac OS image
directory structure
<br>
2) it also fails due to problem 2. below
<br>
2. General bootstrapping problem. The build currently cannot
use itself as
<br>
the bootstrap JDK due to an assumption in the framework
classes that
<br>
"os.arch" is x86_64, whereas we currently set it to amd64.
The change is to
<br>
fix that code to expect amd64. There is a related question
then about what the
<br>
correct value for os.arch should be. I'd like to raise
this in a separate discussion
<br>
and hopefully fix these build problems independently of
that.
<br>
</blockquote>
I was going to propose that we fix the image directory issues by
building into the image directories the same way on all
platforms and have the mac build copy the image directories into
j2sdk-bundle. (7133768) I'm pretty sure that even with this
change you can't build rt.jar because the jar tool gets moved
out from underneath the running build when the bundle is
constructed.
<br>
<br>
I don't think your changes would interfere with my proposed fix
for 7133768, though. And, the other changes for generating the
folder name dynamically are very much welcome.
<br>
<br>
-- Scott K.
<br>
<br>
----------------------------------------
<br>
Scott Kovatch
<br>
<a class="moz-txt-link-abbreviated"
href="mailto:scott.kovatch@oracle.com">scott.kovatch@oracle.com</a>
<br>
Santa Clara/Pleasanton, CA
<br>
<br>
</blockquote>
<br>
</div>
</body>
</html>