<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 3/4/2012 10:12 AM, Kelly O'Hair wrote:
<blockquote
cite="mid:CE0FD53E-AD7C-4E56-A71D-422D78D75E24@oracle.com"
type="cite">
<div><br>
</div>
Did you see this email?'</blockquote>
I didn't. I did not sign up on the build-dev alias until now :)<br>
<blockquote
cite="mid:CE0FD53E-AD7C-4E56-A71D-422D78D75E24@oracle.com"
type="cite">
<div><br>
</div>
<div>Phil Race reviewed it, but I'd like your review too.</div>
</blockquote>
I went through the webrev and noted that it's similar to what you
did for jdk7 when we worked to remove the drop bundle process for
JAXP. The change looks good to me.<br>
<br>
Thanks,<br>
Joe<br>
<br>
<blockquote
cite="mid:CE0FD53E-AD7C-4E56-A71D-422D78D75E24@oracle.com"
type="cite">
<div><br>
</div>
<div>-kto</div>
<div><br>
<div><br>
<div>Begin forwarded message:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="margin-top: 0px; margin-right: 0px;
margin-bottom: 0px; margin-left: 0px;"><span
style="font-family:'Helvetica'; font-size:medium;
color:rgba(0, 0, 0, 1.0);"><b>From: </b></span><span
style="font-family:'Helvetica'; font-size:medium;">"Kelly
O'Hair" <<a moz-do-not-send="true"
href="mailto:kelly.ohair@oracle.com">kelly.ohair@oracle.com</a>><br>
</span></div>
<div style="margin-top: 0px; margin-right: 0px;
margin-bottom: 0px; margin-left: 0px;"><span
style="font-family:'Helvetica'; font-size:medium;
color:rgba(0, 0, 0, 1.0);"><b>Subject: </b></span><span
style="font-family:'Helvetica'; font-size:medium;"><b>Need
reviewer, 7150324: Stop using drop bundles in jaxp </b><br>
</span></div>
<div style="margin-top: 0px; margin-right: 0px;
margin-bottom: 0px; margin-left: 0px;"><span
style="font-family:'Helvetica'; font-size:medium;
color:rgba(0, 0, 0, 1.0);"><b>Date: </b></span><span
style="font-family:'Helvetica'; font-size:medium;">March
2, 2012 12:57:51 PM PST<br>
</span></div>
<div style="margin-top: 0px; margin-right: 0px;
margin-bottom: 0px; margin-left: 0px;"><span
style="font-family:'Helvetica'; font-size:medium;
color:rgba(0, 0, 0, 1.0);"><b>To: </b></span><span
style="font-family:'Helvetica'; font-size:medium;">build-dev
build-dev <<a moz-do-not-send="true"
href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>><br>
</span></div>
<br>
<div><br>
7150324: Stop using drop bundles in jaxp<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eohair/openjdk8/infra-jaxp/webrev/">http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxp/webrev/</a><br>
<br>
I'm working on helping to get the jdk8 build-infra changes
integrated, this is for jaxp.<br>
<br>
This is just the changes to the build files to remove the
use of the drop bundles and add a new Makefile<br>
that won't be used just yet. The ant scripts have been
cleaned up and simplified too.<br>
<br>
The webrevs do not contain the src/ directory addition,
made it too big a webrev.<br>
<br>
I created a make/scripts/update_src.sh script that will
copy in the<br>
latest source drop bundle that was used for this
repository, position it in the src/ directory,<br>
and run the whitespace normalizer script. This script
could be re-used in the future but<br>
it's mostly there to document how I pulled the sources
into the repository.<br>
<br>
Once these changes are reviewed, I would need to:<br>
sh ./make/scripts/update_src.sh&& hg addremove
src<br>
on the repository before creating the changesets that
bring in all these sources.<br>
<br>
I have run builds and verified that the two deliveries
from these repositories (dist/lib/classes.jar<br>
and dist/lib/src.zip) match the ones created before this
change.<br>
The only exception is the whitespace normalization in some
of the sources.<br>
<br>
These changes should not impact the final built jdk bits.<br>
<br>
-kto</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
</body>
</html>