<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
Looks fine,<br>
<br>
-Joe<br>
<br>
On 3/6/2012 9:24 AM, Kelly O'Hair wrote:
<blockquote
cite="mid:3BE8DCB0-4865-4696-A5A7-29F8625C8C2C@oracle.com"
type="cite">Still need a reviewer or 2 on this.
<div><br>
</div>
<div>-kto</div>
<div><br>
<div><br>
<div>Begin forwarded message:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="margin: 0px;"><span style="font-family:
'Helvetica'; font-size: medium; color: rgb(0, 0, 0);"><b>From:
</b></span><span style="font-family: 'Helvetica';
font-size: medium;">"Kelly O'Hair" <<a
moz-do-not-send="true"
href="mailto:kelly.ohair@oracle.com">kelly.ohair@oracle.com</a>><br>
</span></div>
<div style="margin: 0px;"><span style="font-family:
'Helvetica'; font-size: medium; color: rgb(0, 0, 0);"><b>Subject:
</b></span><span style="font-family: 'Helvetica';
font-size: medium;"><b>Need reviewer, 7150322: Stop
using drop source bundles in jaxws </b><br>
</span></div>
<div style="margin: 0px;"><span style="font-family:
'Helvetica'; font-size: medium; color: rgb(0, 0, 0);"><b>Date:
</b></span><span style="font-family: 'Helvetica';
font-size: medium;">March 2, 2012 15:49:28 PM PST<br>
</span></div>
<div style="margin: 0px;"><span style="font-family:
'Helvetica'; font-size: medium; color: rgb(0, 0, 0);"><b>To:
</b></span><span style="font-family: 'Helvetica';
font-size: medium;">build-dev build-dev <<a
moz-do-not-send="true"
href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>><br>
</span></div>
<br>
<div style="word-wrap: break-word;"><span
class="Apple-style-span" style="font-family: monospace;">Similar
to jaxp change, but the source normalization was not
needed.</span>
<div><span class="Apple-style-span" style="font-family:
monospace;"><br>
7150322: Stop using drop source bundles in jaxws<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eohair/openjdk8/infra-jaxws/webrev/">http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxws/webrev/</a><br>
<br>
</span>
<div><span class="Apple-style-span" style="font-family:
monospace;">I'm working on helping to get the jdk8
build-infra changes integrated, this is for jaxws.</span><span
class="Apple-style-span" style="font-family:
monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">This is just the
changes to the build files to remove the use of the
drop bundles and add a new Makefile</span><span
class="Apple-style-span" style="font-family:
monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">that won't be used
just yet. The ant scripts have been cleaned up and
simplified too.</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">The webrevs do not
contain the src/ directory addition, made it too big
a webrev.</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">I created a
make/scripts/update_src.sh script that will copy in
the</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">latest source drop
bundle that was used for this repository, position
it in the src/ directory,</span><span
class="Apple-style-span" style="font-family:
monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">and run the
whitespace normalizer script. This script could be
re-used in the future but</span><span
class="Apple-style-span" style="font-family:
monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">it's mostly there to
document how I pulled the sources into the
repository.</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">Once these changes
are reviewed, I would need to:</span><span
class="Apple-style-span" style="font-family:
monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;"> sh
./make/scripts/update_src.sh&& hg addremove
src</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">on the repository
before creating the changesets that bring in all
these sources.</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">I have run builds
and verified that the two deliveries from these
repositories (dist/lib/classes.jar</span><span
class="Apple-style-span" style="font-family:
monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">and
dist/lib/src.zip) match the ones created before this
change.</span><br>
<font class="Apple-style-span" face="monospace"><br>
</font><span class="Apple-style-span"
style="font-family: monospace;">These changes should
not impact the final built jdk bits.</span><span
class="Apple-style-span" style="font-family:
monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;"><br>
</span><span class="Apple-style-span"
style="font-family: monospace;">-kto</span></div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>