<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#CCCCCC" text="#000000">
Dan,<br>
<br>
I've reviewed all 3 webrevs.<br>
They look fine.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<br>
On 3/30/12 10:32 AM, Daniel D. Daugherty wrote:
<blockquote cite="mid:4F75EE2C.3050505@oracle.com" type="cite">Greetings,
<br>
<br>
In my recent Full Debug Symbols changes, I added the new
<br>
ENABLE_FULL_DEBUG_SYMBOLS build flag. I originally implemented
<br>
this flag to disable debug info for all build configs which
<br>
doesn't make a whole lot of sense for non-product builds. After
all
<br>
what's a debug build without debug info? (Pretty much the same
<br>
thing as a product build).
<br>
<br>
As is usual, I have one bug to track the hotspot repo changes and
<br>
another bug to track the other repos:
<br>
<br>
7157296 3/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only
affect
<br>
OPT builds
<br>
7158067 4/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only
affect
<br>
product builds
<br>
<br>
Here are the webrev URLs:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dcubed/fds_revamp/7157296-webrev/0-jdk8-root/">http://cr.openjdk.java.net/~dcubed/fds_revamp/7157296-webrev/0-jdk8-root/</a>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dcubed/fds_revamp/7158067-webrev/0-jdk8-hotspot/">http://cr.openjdk.java.net/~dcubed/fds_revamp/7158067-webrev/0-jdk8-hotspot/</a>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dcubed/fds_revamp/7157296-webrev/0-jdk8-jdk/">http://cr.openjdk.java.net/~dcubed/fds_revamp/7157296-webrev/0-jdk8-jdk/</a>
<br>
<br>
Thanks, in advance, for any review comments.
<br>
<br>
Dan
<br>
<br>
</blockquote>
<br>
</body>
</html>