<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#ffffff" text="#000000">
    <br>
    <br>
    On 2012-04-04 16:56, Jonathan Gibbons wrote:
    <blockquote cite="mid:4F7C610E.7010104@oracle.com" type="cite">
      <meta content="text/html; charset=ISO-8859-1"
        http-equiv="Content-Type">
      In langtools/Makefile, <br>
      <br>
      line 42, bad/inappropriate/editorial comment:<br>
      "A more palatable solution would be to add the GenStubs
      functionality to javac."<br>
      It would be totally unacceptable to add GenStubs to javac, so the
      comment is irrelevant.<br>
    </blockquote>
    Removing<br>
    <blockquote cite="mid:4F7C610E.7010104@oracle.com" type="cite"> <br>
      line 120, 130-138, the nio files are not required when building on
      JDK 7.<br>
    </blockquote>
    I'm not very familiar with this functionality. Are you recommending
    us to completely disable this part for now as it isn't needed right
    now?<br>
    <blockquote cite="mid:4F7C610E.7010104@oracle.com" type="cite"> <br>
      line 179, what is "javax.tools.JavaCompilerTool" and why is it
      listed as in RESOURCE_SUFFIXES<br>
    </blockquote>
    It's possible we could express this differently. It's a file that
    needs to be copied as a resource (from source to classes dir) and
    this was the easiest way I found of getting it to be copied. Adding
    a comment to explain it for now.<br>
    <blockquote cite="mid:4F7C610E.7010104@oracle.com" type="cite"> line
      194, is the JARMAIN required? It should not be used downstream, so
      does it need to be set here?<br>
    </blockquote>
    Probably not. Removing and testing.<br>
    <blockquote cite="mid:4F7C610E.7010104@oracle.com" type="cite"> <br>
      -- Jon<br>
      <br>
      <br>
      <br>
      On 04/04/2012 07:41 AM, Erik Joelsson wrote:
      <blockquote cite="mid:4F7C5DAA.6070107@oracle.com" type="cite">
        <meta content="text/html; charset=ISO-8859-1"
          http-equiv="Content-Type">
        One final review update. Cleanup of configure help output and
        make help target in root repo.<br>
        <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-root-new.03/">http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-root-new.03/</a><br>
        <br>
        /Erik<br>
        <br>
        On 2012-04-03 11:59, Erik Joelsson wrote:
        <blockquote cite="mid:4F7ACA02.1040302@oracle.com" type="cite">
          <meta content="text/html; charset=ISO-8859-1"
            http-equiv="Content-Type">
          Fixed these comments and posted new webrevs:<br>
          <br>
          <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-corba-new.02/">http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-corba-new.02/</a><br>
          <br>
          <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-langtools-new.02/">http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-langtools-new.02/</a><br>
          <br>
          (Tried making a single webrev but my forest extension isn't
          working that well)<br>
          <br>
          /Erik<br>
          <br>
          On 2012-03-30 20:08, Kelly O'Hair wrote:
          <blockquote
            cite="mid:2D3C0F04-2D20-4B55-8B1B-4210C9F5EFE2@oracle.com"
            type="cite">
            <pre>Corba Makefile says:  45 # Thus we force the target bytecode to 6.</pre>
            <div>But I think 6 should be 7, or better yet <span
                class="Apple-style-span" style="font-family: monospace;
                white-space: pre;"> </span><span
                class="Apple-style-span" style="font-family: monospace;
                white-space: pre;">"...the<br>
                <br>
                boot<br>
                <br>
                <br>
                <br>
                jdk target bytecode."</span></div>
            <div><span class="Apple-style-span" style="font-family:
                monospace; white-space: pre;"><br>
                <br>
                <br>
                <br>
                <br>
                <br>
                <br>
                <br>
              </span></div>
            <div><span class="Apple-style-span" style="font-family:
                monospace; white-space: pre;">Everything else looks ok
                to<br>
                <br>
                me.</span></div>
            <div><br>
            </div>
            <div>-kto</div>
            <div><br>
            </div>
            <br>
          </blockquote>
          <br>
          On 2012-03-30 15:19, Jonathan Gibbons wrote:
          <blockquote cite="mid:4F75B2C6.7090004@oracle.com" type="cite">
            langtools makefile...<br>
            <br>
            line 55 typo in comment "ony"<br>
            <br>
            line 57 grammar in comment "list of to be created"<br>
            <br>
            The Swedish examples are somewhat silly since there are no
            swedish properties files.<br>
            <br>
            The comments on line 92--94 are inaccurate: javac is only
            build twice, not three times.<br>
            <br>
            line 130: grammar, should be either "strip them of all
            content" or "strip all content from them"<br>
            <br>
            line 168: not clear what "this setup" refers to.<br>
            <br>
            -- Jon</blockquote>
          <br>
        </blockquote>
      </blockquote>
      <br>
    </blockquote>
  </body>
</html>